Lint: Adding more checks for non internationalized strings #5625
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎭 Playwright Test Results⏰ Completed at: 10/30/2025, 03:59:53 AM UTC 📈 Summary
📊 Test Reports by Browser
🎉 Click on the links above to view detailed test results for each browser configuration. |
DrJKL
changed the title
This was referenced Sep 17, 2025
arjansingh
previously approved these changes
Sep 17, 2025
|
SGTM! |
|
I'm not a frontend engineer, so I can't review this change. Claude can do better, haha. |
dosubot
bot
added
the
size:S
2 tasks
DrJKL
pushed a commit
that referenced
this pull request
Oct 20, 2025
## Summary - Fix i18n linting errors by adding missing locale keys to `src/locales/en/main.json` - Update all affected components to use `$t()` for internationalization ## Changes Added the following locale keys: - `comfyOrgLogoAlt`: "ComfyOrg Logo" - `comfy`: "Comfy" - `pressKeysForNewBinding`: "Press keys for new binding" - `defaultBanner`: "default banner" - `enableOrDisablePack`: "Enable or disable pack" - `openManager`: "Open Manager" - `graphNavigation`: "Graph navigation" Updated components to use i18n keys: - `ComfyOrgHeader.vue` - `KeybindingPanel.vue` - `PackBanner.vue` - `PackIcon.vue` - `PackEnableToggle.vue` - `LoadWorkflowWarning.vue` - `SubgraphBreadcrumb.vue` - `SignInContent.vue` ## Test plan - [x] Run `pnpm lint` - all i18n linting errors resolved - [x] Pre-commit hooks pass Aim to make #5625 CI/CD pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6170-bugfix-Fix-i18n-linting-errors-2926d73d365081c3b7fbcbbf4a8e03d6) by [Unito](https://www.unito.io) Co-authored-by: Claude <[email protected]>
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
aac1538 to
f61ab10
Compare
🎨 Storybook Build Status✅ Build completed successfully! ⏰ Completed at: 10/30/2025, 03:47:58 AM UTC 🔗 Links🎉 Your Storybook is ready for review! |
Bundle Size ReportSummary
Category Glance Per-category breakdownApp Entry Points — 3.31 MB (baseline 3.31 MB) • ⚪ 0 BMain entry bundles and manifests
Graph Workspace — 718 kB (baseline 718 kB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Views & Navigation — 8.14 kB (baseline 8.14 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Panels & Settings — 294 kB (baseline 294 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
UI Components — 12.3 kB (baseline 12.3 kB) • ⚪ 0 BReusable component library chunks
Data & Services — 10 kB (baseline 10 kB) • ⚪ 0 BStores, services, APIs, and repositories
Utilities & Hooks — 1.07 kB (baseline 1.07 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Vendor & Third-Party — 5.36 MB (baseline 5.36 MB) • ⚪ 0 BExternal libraries and shared vendor chunks
Other — 2.55 MB (baseline 2.55 MB) • ⚪ 0 BBundles that do not match a named category
|
Myestery
reviewed
Oct 20, 2025
Myestery
approved these changes
Oct 20, 2025
|
we could also fix the failing tests associated with the new rules |
Yeah, I wasn't planning on merging this until they were updated. It was a draft, but @snomiao kicked things off with the other PR |
christian-byrne
approved these changes
Oct 21, 2025
|
*clicked update branch |
christian-byrne
pushed a commit
that referenced
this pull request
Oct 27, 2025
## Summary This PR fixes all @intlify/vue-i18n/no-raw-text linting errors identified in #5625 by replacing raw text strings with proper i18n translation function calls. ## Changes Fixed i18n linting errors in the following files: - `src/components/widget/SampleModelSelector.vue` - "Upload Model" → `$t('g.upload')` - `src/components/topbar/CurrentUserButton.vue` - "user profile" → `$t('g.currentUser')` - `src/components/sidebar/tabs/nodeLibrary/NodeHelpPage.vue` - "Loading help" → `$t('g.loading')` - `src/components/sidebar/SidebarShortcutsToggleButton.vue` - "shortcuts.shortcuts" → `$t('shortcuts.shortcuts')` - `src/components/sidebar/SidebarLogoutIcon.vue` - "sideToolbar.logout" → `$t('sideToolbar.logout')` - `src/components/sidebar/SidebarHelpCenterIcon.vue` - "menu.help" → `$t('menu.help')` - `src/components/sidebar/SidebarBottomPanelToggleButton.vue` - "sideToolbar.labels.console" → `$t('sideToolbar.labels.console')` - `src/components/load3d/controls/viewer/ViewerCameraControls.vue` - "fov" → `t('load3d.fov')` - `src/components/helpcenter/HelpCenterMenuContent.vue` - "Help Center Menu" and "Recent releases" → `$t()` calls All raw text strings have been replaced with appropriate i18n translation keys that already exist in `src/locales/en/main.json`. ## Related Issue Fixes errors reported in CI job: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/18705105609/job/53341658467?pr=5625 This PR aims to help #5625 pass CI/CD checks. ## Test Plan - All i18n linting errors should be resolved - No functionality changes - only proper use of i18n system - Existing translation keys are used from the locale files ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-6280-bugfix-fix-intlify-vue-i18n-no-raw-text-linting-errors-2976d73d365081369b43de01486fb409) by [Unito](https://www.unito.io) --------- Co-authored-by: GitHub Action <[email protected]>
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
7f2bc07 to
3d73aed
Compare
DrJKL
force-pushed
the
drjkl/i18n-linting
branch
from
3d73aed to
d5e8da4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Catch more user visible (or audible) text that isn't internationalizable.
Changes
Review Focus
What other properties have leaked English text to non-English locales that aren't in here?